Messages in this thread |  | | | From | "NeilBrown" <> | | Date | Thu, 12 Feb 2009 14:15:06 +1100 (EST) | | Subject | Re: [PATCH] nfs: replace uses of __constant_{endian} |
| |
On Thu, February 12, 2009 1:52 pm, Harvey Harrison wrote: > On Thu, 2009-02-12 at 13:50 +1100, NeilBrown wrote: >> On Thu, February 12, 2009 12:16 pm, Harvey Harrison wrote: >> > The base versions handle constant folding now, none of these headers >> > are exported to userspace, so the __ prefixed versions are not >> > necessary. >> >> I assume you compile tested this? >> >> I seem to recall that the reason we did it that way was that >> some of the error codes are used in switch statements, and >> the value for a 'case:' really has to look like a constant, not just >> happen to evaluate to one. > > Yes, this requirement was explicitly built-in. See how the various > __swabXX bits are done in linux/swab.h.
Cool, thanks!
NeilBrown
|  |