Messages in this thread | | | Date | Wed, 11 Feb 2009 20:30:21 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 4/6] ide: add ->dma_expiry method and remove ->dma_exec_cmd one |
| |
Hello.
Bartlomiej Zolnierkiewicz wrote:
>>Bartlomiej Zolnierkiewicz wrote:
>>>* Rename dma_timer_expiry() to ide_dma_sff_expiry() and export it.
>>>* Add ->dma_expiry method
>> This name doesn't seem to make much sense. Why not leave it dma_timer_expiry?
> Well, the name matches with hwif->expiry one + the downside of leaving it at > dma_timer_expiry is a need to reformat all struct ide_dma_ops instances...
How about just timer_expiry() then?
> Thanks, > Bart
MBR, Sergei
| |