Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 4/6] ide: add ->dma_expiry method and remove ->dma_exec_cmd one | Date | Wed, 11 Feb 2009 17:30:39 +0100 |
| |
On Tuesday 10 February 2009, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > > * Rename dma_timer_expiry() to ide_dma_sff_expiry() and export it. > > > * Add ->dma_expiry method > > This name doesn't seem to make much sense. Why not leave it dma_timer_expiry?
Well, the name matches with hwif->expiry one + the downside of leaving it at dma_timer_expiry is a need to reformat all struct ide_dma_ops instances...
Thanks, Bart
| |