Messages in this thread | | | Date | Tue, 10 Feb 2009 12:57:52 -0800 | From | Greg KH <> | Subject | Re: [patch 33/41] asus-laptop: Fix the led behavior with value > 1 |
| |
On Tue, Feb 10, 2009 at 09:24:29PM +0100, Pavel Machek wrote: > On Wed 2009-02-04 10:46:54, Greg KH wrote: > > 2.6.27-stable review patch. If anyone has any objections, please let us know. > > > > ------------------ > > > > From: Corentin Chary <corentincj@iksaif.net> > > > > commit e3deda9c87ac5eef2b5d18cd0b5511370979ca26 upstream. > > > > Fix http://bugzilla.kernel.org/show_bug.cgi?id=11613 . > > > > Signed-off-by: Corentin Chary <corentincj@iksaif.net> > > Signed-off-by: Len Brown <len.brown@intel.com> > > Cc: Thomas Renninger <trenn@suse.de> > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > > > --- > > drivers/misc/asus-laptop.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/drivers/misc/asus-laptop.c > > +++ b/drivers/misc/asus-laptop.c > > @@ -351,7 +351,7 @@ static void write_status(acpi_handle han > > static void object##_led_set(struct led_classdev *led_cdev, \ > > enum led_brightness value) \ > > { \ > > - object##_led_wk = value; \ > > + object##_led_wk = (value > 0) ? 1 : 0; \ > > "= !!value" is standard way to do that.... for unsigned value.
No dispute here, but that's what is upstream :)
thanks,
greg k-h
| |