Messages in this thread | | | Date | Tue, 10 Feb 2009 21:24:05 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] Kbuild: Disable the -Wformat-security gcc flag |
| |
On Wed 2009-02-04 14:26:45, Roland Dreier wrote: > > Before judging on this patch could you please post what warning it > > triggers and one or a few patches to fix some of them. > > The warnings are things like: > > init/main.c: In function 'start_kernel': > init/main.c:557: warning: format not a string literal and no format arguments >
Would it be possible to declare linux_banner const or something?
> diff --git a/init/main.c b/init/main.c > index 8442094..78fc0d8 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -554,7 +554,7 @@ asmlinkage void __init start_kernel(void) > boot_cpu_init(); > page_address_init(); > printk(KERN_NOTICE); > - printk(linux_banner); > + printk("%s", linux_banner);
Actually printk(KERN_NOTICE "%s", linux_banner);
is a better fix that will save some code, too.
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |