lkml.org 
[lkml]   [2009]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 22/53] e1000: fix bug with shared interrupt during reset
    2.6.28-stable review patch.  If anyone has any objections, please let us know.
    ------------------

    From: Jesse Brandeburg <jesse.brandeburg@intel.com>

    commit 15b2bee22a0390d951301b53e83df88d0350c499 upstream.

    A nasty bug was found where an MTU change (or anything else that caused a
    reset) could race with the interrupt code. The interrupt code was entered
    by a shared interrupt during the MTU change.

    This change prevents the interrupt code from running while the driver is in
    the middle of its reset path.

    Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    --- a/drivers/net/e1000/e1000_main.c
    +++ b/drivers/net/e1000/e1000_main.c
    @@ -31,7 +31,7 @@

    char e1000_driver_name[] = "e1000";
    static char e1000_driver_string[] = "Intel(R) PRO/1000 Network Driver";
    -#define DRV_VERSION "7.3.20-k3-NAPI"
    +#define DRV_VERSION "7.3.21-k3-NAPI"
    const char e1000_driver_version[] = DRV_VERSION;
    static const char e1000_copyright[] = "Copyright (c) 1999-2006 Intel Corporation.";

    @@ -3712,7 +3712,7 @@ static irqreturn_t e1000_intr(int irq, void *data)
    struct e1000_hw *hw = &adapter->hw;
    u32 rctl, icr = er32(ICR);

    - if (unlikely(!icr))
    + if (unlikely((!icr) || test_bit(__E1000_RESETTING, &adapter->flags)))
    return IRQ_NONE; /* Not our interrupt */

    /* IMS will not auto-mask if INT_ASSERTED is not set, and if it is


    \
     
     \ /
      Last update: 2009-02-10 20:15    [W:0.019 / U:31.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site