lkml.org 
[lkml]   [2009]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] crypto: compress - Add pcomp interface
    On Thu, Feb 05, 2009 at 05:24:51PM +0100, Geert Uytterhoeven wrote:
    >
    > > Well with the netlink parameters these can have variable lengths
    > > depending on how many parameters the user supplies.
    >
    > How can this be exported to userspace?
    > How does this variable length parameter passing work? Do you have an example?

    See how we use it for rtnetlink, e.g., in net/ipv4/ip_gre.c.

    > Nothing in crypto/ seems to already use nla_*?

    Well we don't have a user-space API yet :) But checkout the
    discussions on this list.

    > While the core of the crypto system supports two algorithms of the same name
    > with different types, the testmgr doesn't.

    I was lazy :) But really it isn't too hard to add a type field to
    the array in testmgr. We don't even have to add it for existing
    entries (except for the ones that you're trying to replace, i.e.,
    deflate).

    > As I removed the backwards-compatility layer at your request, I'll use "zlib"
    > for the name of the new module. It's more flexible than the fixed "deflate"
    > one anyway.
    >
    > Is this OK for you?

    Hmm, I think we need to have it stay as deflate if we're to make
    an easy transition for existing users (e.g., IPsec).

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2009-02-10 07:21    [W:0.022 / U:33.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site