Messages in this thread Patch in this message | | | Date | Sun, 1 Feb 2009 23:01:41 +0530 | Subject | Re: [git pull -tip] headers_check fixes for other architectures | From | Jaswinder Singh Rajput <> |
| |
On Sun, Feb 1, 2009 at 10:50 PM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Sun, Feb 01, 2009 at 05:49:15PM +0100, Ingo Molnar wrote: >> >> * Ingo Molnar <mingo@elte.hu> wrote: >> >> > > These patches fixes 41 headers_check warnings as shown in first email. >> > >> > Pulled into tip/core/header-fixes, thanks Jaswinder! >> >> These are the remaining ones on x86: >> >> 17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h >> 12 /dev/shm/tip/usr/include/linux/soundcard.h >> 6 /dev/shm/tip/usr/include/asm/setup.h >> 3 /dev/shm/tip/usr/include/linux/nubus.h >> 2 /dev/shm/tip/usr/include/linux/in6.h >> 1 /dev/shm/tip/usr/include/mtd/jffs2-user.h >> 1 /dev/shm/tip/usr/include/linux/socket.h >> 1 /dev/shm/tip/usr/include/linux/coda_psdev.h >> 1 /dev/shm/tip/usr/include/asm/prctl.h >> >> They are all of the "extern's make no sense in userspace" type. What was the >> verdict, are they worth touching, or should we turn off this warning in >> 'make headers_check'? > > Ah, not a case of new-cc's added. A case of the rare event of non-spam > eminating from hera.kernel.org falling foul of my manual local blacklist. > > I'd appreciate it if someone could point me at the original patches > being discussed.
I am sorry, if you did not received the email but you was in CC list:
Ingo Molnar <mingo@elte.hu>, Linus Torvalds <torvalds@linux-foundation.org>, Sam Ravnborg <sam@ravnborg.org>, Andrew Morton <akpm@linux-foundation.org>, Russell King - ARM Linux <linux@arm.linux.org.uk>, hskinnemoen@atmel.com, cooloney@kernel.org, tony.luck@intel.com, ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx, chris@zankel.net, LKML <linux-kernel@vger.kernel.org>
Arms bits are :
These are clean patches, I did not included anything which leads to any confusion or conflicts. I hope maintainers do not mind if these patches go to mainstream via Ingo's -tip along with other headers_check fixes.
Jaswinder Singh Rajput (3): headers_check fix: arm, a.out.h headers_check fix: arm, setup.h headers_check fix: arm, swab.h
diff --git a/arch/arm/include/asm/a.out.h b/arch/arm/include/asm/a.out.h index 79489fd..083894b 100644 --- a/arch/arm/include/asm/a.out.h +++ b/arch/arm/include/asm/a.out.h @@ -2,7 +2,7 @@ #define __ARM_A_OUT_H__
#include <linux/personality.h> -#include <asm/types.h> +#include <linux/types.h>
struct exec { diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h index f2cd18a..ee1304f 100644 --- a/arch/arm/include/asm/setup.h +++ b/arch/arm/include/asm/setup.h @@ -14,7 +14,7 @@ #ifndef __ASMARM_SETUP_H #define __ASMARM_SETUP_H
-#include <asm/types.h> +#include <linux/types.h>
#define COMMAND_LINE_SIZE 1024
diff --git a/arch/arm/include/asm/swab.h b/arch/arm/include/asm/swab.h index 27a689b..ca2bf2f 100644 --- a/arch/arm/include/asm/swab.h +++ b/arch/arm/include/asm/swab.h @@ -16,7 +16,7 @@ #define __ASM_ARM_SWAB_H
#include <linux/compiler.h> -#include <asm/types.h> +#include <linux/types.h>
#if !defined(__STRICT_ANSI__) || defined(__KERNEL__) # define __SWAB_64_THRU_32__ Thanks, -- JSR
| |