[lkml]   [2009]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] sungem: limit reaches -1, but 0 tested
    From: Roel Kluin <>
    Date: Sat, 31 Jan 2009 13:42:36 +0100

    > With a postfix decrement these reach -1 rather than 0,
    > but after the loop it is tested to have become 0.
    > Signed-off-by: Roel Kluin <>

    Just like the case just pointed out in your 'net' version
    of this patch, it is being tested "<= 0" so this fix
    is not necessary at all.

    Please carefully review all of your changes of this kind
    to make sure the test is strictly equality to zero rather
    than <= 0.

    I'm dropping all of these postfix decrement patches.

     \ /
      Last update: 2009-02-01 11:03    [W:0.019 / U:5.004 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site