Messages in this thread | | | Date | Sun, 01 Feb 2009 01:59:31 -0800 (PST) | Subject | Re: [PATCH] sungem: limit reaches -1, but 0 tested | From | David Miller <> |
| |
From: Roel Kluin <roel.kluin@gmail.com> Date: Sat, 31 Jan 2009 13:42:36 +0100
> With a postfix decrement these reach -1 rather than 0, > but after the loop it is tested to have become 0. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Just like the case just pointed out in your 'net' version of this patch, it is being tested "<= 0" so this fix is not necessary at all.
Please carefully review all of your changes of this kind to make sure the test is strictly equality to zero rather than <= 0.
I'm dropping all of these postfix decrement patches.
| |