lkml.org 
[lkml]   [2009]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH 3/8] ide-tape: remove superfluous tape->lock
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] ide-tape: remove superfluous tape->lock

tape->lock is not needed (->queue_lock protects queue).

Cc: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide-tape.c | 9 ---------
1 file changed, 9 deletions(-)
Index: b/drivers/ide/ide-tape.c
===================================================================
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -245,9 +245,6 @@ typedef struct ide_tape_obj {
/* Wasted space in each stage */
int excess_bh_size;

- /* protects the ide-tape queue */
- spinlock_t lock;
-
/* Measures average tape speed */
unsigned long avg_time;
int avg_size;
@@ -481,7 +478,6 @@ static int idetape_end_request(ide_drive
{
struct request *rq = drive->hwif->rq;
idetape_tape_t *tape = drive->driver_data;
- unsigned long flags;
int error;

debug_log(DBG_PROCS, "Enter %s\n", __func__);
@@ -500,11 +496,8 @@ static int idetape_end_request(ide_drive
return 0;
}

- spin_lock_irqsave(&tape->lock, flags);
-
ide_complete_rq(drive, 0);

- spin_unlock_irqrestore(&tape->lock, flags);
return 0;
}

@@ -2192,8 +2185,6 @@ static void idetape_setup(ide_drive_t *d
drive->pc_update_buffers = idetape_update_buffers;
drive->pc_io_buffers = ide_tape_io_buffers;

- spin_lock_init(&tape->lock);
-
drive->dev_flags |= IDE_DFLAG_DSC_OVERLAP;

if (drive->hwif->host_flags & IDE_HFLAG_NO_DSC) {

\
 
 \ /
  Last update: 2009-02-01 20:31    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site