lkml.org 
[lkml]   [2009]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] arch/x86/kernel/microcode*: Use pr_fmt and remove duplicated KERN_ERR prefix

    * Joe Perches <joe@perches.com> wrote:

    > On Wed, 2009-12-09 at 07:05 +0100, Ingo Molnar wrote:
    > > > > - printk(KERN_ERR "microcode: CPU%d: loading of chipset "
    > > > > + pr_err(KERN_ERR "microcode: CPU%d: loading of chipset "
    > > > Duplicates KERN_ERR
    > > Indeed - please send a delta fix as this has been merged already.
    >
    > Use #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
    > Remove "microcode: " prefix from each pr_<level>
    > Fix duplicated KERN_ERR prefix
    > Coalesce pr_<level> format strings
    > Add a space after an exclamation point
    > No other change in output
    >
    > Signed-off-by: Joe Perches <joe@perches.com>
    > ---
    > arch/x86/kernel/microcode_amd.c | 40 +++++++++++++++----------------
    > arch/x86/kernel/microcode_core.c | 26 +++++++++++---------
    > arch/x86/kernel/microcode_intel.c | 47 +++++++++++++++---------------------
    > 3 files changed, 53 insertions(+), 60 deletions(-)

    very nice. I've applied it, thanks Joe!

    Ingo


    \
     
     \ /
      Last update: 2009-12-09 08:29    [W:0.023 / U:61.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site