Messages in this thread Patch in this message | | | Date | Wed, 9 Dec 2009 20:25:59 +0100 (CET) | From | Julia Lawall <> | Subject | [PATCH 11/12] net/mac80211: Correct size given to memset |
| |
From: Julia Lawall <julia@diku.dk>
Memset should be given the size of the structure, not the size of the pointer.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ type T; T *x; expression E; @@
memset(x, E, sizeof( + * x)) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- net/mac80211/mesh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/net/mac80211/mesh.c b/Net/mac80211/mesh.c --- a/net/mac80211/mesh.c +++ b/net/mac80211/mesh.c @@ -427,7 +427,7 @@ int ieee80211_new_mesh_header(struct iee char *addr5, char *addr6) { int aelen = 0; - memset(meshhdr, 0, sizeof(meshhdr)); + memset(meshhdr, 0, sizeof(*meshhdr)); meshhdr->ttl = sdata->u.mesh.mshcfg.dot11MeshTTL; put_unaligned(cpu_to_le32(sdata->u.mesh.mesh_seqnum), &meshhdr->seqnum); sdata->u.mesh.mesh_seqnum++;
| |