Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 2/2] cfq-iosched: Take care of corner cases of group losing share due to deletion | Date | Wed, 09 Dec 2009 14:06:10 -0500 |
| |
Vivek Goyal <vgoyal@redhat.com> writes:
> Reported-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com> > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> + /* > + * If think times is less than a jiffy than ttime_mean=0 and above > + * will not be true. It might happen that slice has not expired yet > + * but will expire soon (4-5 ns) during select_queue(). To cover the
4-5ns? I'm not sure why you chose these numbers. Is that what you saw in testing? Anyway, I'm ok with the change, I dislike the reference to time when a single jiffy could be up to 10ms.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
| |