Messages in this thread |  | | | Date | Wed, 09 Dec 2009 09:51:14 -0500 (EST) | | From | Nicolas Pitre <> | | Subject | Re: [PATCH] smc91x: fix unused flags warnings on UP systems |
| |
On Wed, 9 Dec 2009, Mike Frysinger wrote:
> Local flags variables will be declared whenever these functions get used, > but obviously on UP systems the flags parameter won't be touched. So add > some dummy ops that get optimized away anyways to satisfy gcc's warnings. > > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Nicolas Pitre <nico@fluxnic.net>
> --- > drivers/net/smc91x.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c > index ae4983a..b0c92b6 100644 > --- a/drivers/net/smc91x.c > +++ b/drivers/net/smc91x.c > @@ -534,9 +534,9 @@ static inline void smc_rcv(struct net_device *dev) > #define smc_special_lock(lock, flags) spin_lock_irqsave(lock, flags) > #define smc_special_unlock(lock, flags) spin_unlock_irqrestore(lock, flags) > #else > -#define smc_special_trylock(lock, flags) (1) > -#define smc_special_lock(lock, flags) do { } while (0) > -#define smc_special_unlock(lock, flags) do { } while (0) > +#define smc_special_trylock(lock, flags) (flags == flags) > +#define smc_special_lock(lock, flags) do { flags = 0; } while (0) > +#define smc_special_unlock(lock, flags) do { flags = 0; } while (0) > #endif > > /* > -- > 1.6.5.5 >
|  |