Messages in this thread | | | Date | Tue, 08 Dec 2009 23:26:25 +0100 | From | Jiri Slaby <> | Subject | Re: + hpsa-use-msleep-instead-of-schedule_timeout.patch added to -mm tree |
| |
On 12/08/2009 11:25 PM, Jiri Slaby wrote: >> @@ -3302,7 +3302,8 @@ static int __devinit hpsa_init_one(struc >> >> /* Some devices (notably the HP Smart Array 5i Controller) >> need a little pause here */ >> - schedule_timeout_uninterruptible(HPSA_POST_RESET_PAUSE); >> + set_current_state(TASK_UNINTERRUPTIBLE); >> + msleep(HPSA_POST_RESET_PAUSE_MSECS); > > Hmm, setting the state is superfluous, as msleep does the job itself.
(FWIW addressed by Andrew already.)
-- js
| |