lkml.org 
[lkml]   [2009]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 5/8] Loongson: YeeLoong: add hardware monitoring driver
From
Date
On Tue, 2009-12-08 at 08:09 +0100, Pavel Machek wrote:
> > > > > That's certainly better. But... why not return signed value? Current
> > > > > flowing from the battery is certainly very different from current
> > > > > flowing into it...
> > > >
> > > > You are totally right ;)
> > > >
> > > > Just test it, when flowing from the battery, the value is negative, and
> > > > when flowing into the battery, the value is positive, so, no abs()
> > > > needed. thanks!
> > >
> > > Make it return -value, then. I believe other code uses >0 values for
> > > discharge.
> >
> > Done, but any document/standard about it?
>
> Not sure, feel free to patch the documentation, too :-).

Okay, I will send a documentation(as a separate patch) like them:

$ ls Documentation/ABI/testing/sysfs-platform-*
Documentation/ABI/testing/sysfs-platform-asus-laptop
Documentation/ABI/testing/sysfs-platform-eeepc-laptop

Thanks & Regards,
Wu Zhangjin



\
 
 \ /
  Last update: 2009-12-08 08:29    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site