lkml.org 
[lkml]   [2009]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2/2] x86,apic: Use logical OR in noop-write operation
    On Tue, Dec 08, 2009 at 06:53:18PM +0300, Cyrill Gorcunov wrote:
    > For apic noop'ified we have to use logical OR statement,
    > otherwise any write on systems shipped with 82489DX
    > (where apic presence bit can't be retrieved via cpuid)
    > will not trigger the warning which is not desired.
    >
    ...

    Ingo please dont apply this patch. Perhaps we may warn unconditionally
    (as Peter marked) which would be more clear approach indeed. Need more
    time to check all code flows.

    Sorry for inconvenience.

    -- Cyrill


    \
     
     \ /
      Last update: 2009-12-08 21:51    [W:3.408 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site