lkml.org 
[lkml]   [2009]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v8 5/8] Loongson: YeeLoong: add hardware monitoring driver
    From
    Date
    Hi, Pavel Machek

    After fixing the get_battery_current(), can I get your Acked-by: for the
    next revision of this patch?

    Thanks!
    Wu Zhangjin

    On Mon, 2009-12-07 at 10:49 +0100, Pavel Machek wrote:
    > On Mon 2009-12-07 17:41:10, Wu Zhangjin wrote:
    > > On Mon, 2009-12-07 at 09:04 +0100, Pavel Machek wrote:
    > > > > > What is going on here? I thought the value is already in two's
    > > > > > complement... Is the above equivalent of
    > > > > >
    > > > > > if (value < 0)
    > > > > > value = -value;
    > > > > >
    > > > > > ? If so, why? If not, can you add a comment?
    > > > >
    > > > > Right, then, will use this instead:
    > > > >
    > > > > static int get_battery_current(void)
    > > > > {
    > > > > s16 value;
    > > > >
    > > > > value = (ec_read(REG_BAT_CURRENT_HIGH) << 8) |
    > > > > (ec_read(REG_BAT_CURRENT_LOW));
    > > > >
    > > > > return abs(value);
    > > > > }
    > > >
    > > > That's certainly better. But... why not return signed value? Current
    > > > flowing from the battery is certainly very different from current
    > > > flowing into it...
    > >
    > > You are totally right ;)
    > >
    > > Just test it, when flowing from the battery, the value is negative, and
    > > when flowing into the battery, the value is positive, so, no abs()
    > > needed. thanks!
    >
    > Make it return -value, then. I believe other code uses >0 values for
    > discharge.
    > Pavel
    >




    \
     
     \ /
      Last update: 2009-12-08 07:53    [W:0.040 / U:1.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site