lkml.org 
[lkml]   [2009]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 13/13] ksym_tracer: Fix compile warnings
    Fix these 2 warnings:

    kernel/trace/trace_ksym.c: In function 'ksym_trace_filter_read':
    kernel/trace/trace_ksym.c:239: warning: cast to pointer from integer of different size
    kernel/trace/trace_ksym.c: In function 'ksym_trace_filter_write':
    kernel/trace/trace_ksym.c:295: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    ---
    kernel/trace/trace_ksym.c | 13 +++++++------
    1 files changed, 7 insertions(+), 6 deletions(-)

    diff --git a/kernel/trace/trace_ksym.c b/kernel/trace/trace_ksym.c
    index acb87d4..e393146 100644
    --- a/kernel/trace/trace_ksym.c
    +++ b/kernel/trace/trace_ksym.c
    @@ -236,7 +236,8 @@ static ssize_t ksym_trace_filter_read(struct file *filp, char __user *ubuf,
    mutex_lock(&ksym_tracer_mutex);

    hlist_for_each_entry(entry, node, &ksym_filter_head, ksym_hlist) {
    - ret = trace_seq_printf(s, "%pS:", (void *)entry->attr.bp_addr);
    + ret = trace_seq_printf(s, "%pS:",
    + (void *)(unsigned long)entry->attr.bp_addr);
    if (entry->attr.bp_type == HW_BREAKPOINT_R)
    ret = trace_seq_puts(s, "r--\n");
    else if (entry->attr.bp_type == HW_BREAKPOINT_W)
    @@ -278,7 +279,7 @@ static ssize_t ksym_trace_filter_write(struct file *file,
    {
    struct trace_ksym *entry;
    struct hlist_node *node;
    - char *input_string, *ksymname = NULL;
    + char *input_string, *buf, *ksymname = NULL;
    unsigned long ksym_addr = 0;
    int ret, op, changed = 0;

    @@ -292,7 +293,7 @@ static ssize_t ksym_trace_filter_write(struct file *file,
    }
    input_string[count] = '\0';

    - strstrip(input_string);
    + buf = strstrip(input_string);

    /*
    * Clear all breakpoints if:
    @@ -300,14 +301,14 @@ static ssize_t ksym_trace_filter_write(struct file *file,
    * 2: echo 0 > ksym_trace_filter
    * 3: echo "*:---" > ksym_trace_filter
    */
    - if (!input_string[0] || !strcmp(input_string, "0") ||
    - !strcmp(input_string, "*:---")) {
    + if (!buf[0] || !strcmp(buf, "0") ||
    + !strcmp(buf, "*:---")) {
    __ksym_trace_reset();
    kfree(input_string);
    return count;
    }

    - ret = op = parse_ksym_trace_str(input_string, &ksymname, &ksym_addr);
    + ret = op = parse_ksym_trace_str(buf, &ksymname, &ksym_addr);
    if (ret < 0) {
    kfree(input_string);
    return ret;
    --
    1.6.3


    \
     
     \ /
      Last update: 2009-12-08 04:21    [W:0.048 / U:0.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site