Messages in this thread | | | Date | Mon, 7 Dec 2009 15:03:42 +0100 | From | Martin Schwidefsky <> | Subject | Re: [PATCH] tty: PTR_ERR return of wrong pointer in fs3270_open() |
| |
On Mon, 07 Dec 2009 14:33:39 +0100 Roel Kluin <roel.kluin@gmail.com> wrote:
> Return the PTR_ERR of the correct pointer. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > drivers/s390/char/fs3270.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/s390/char/fs3270.c b/drivers/s390/char/fs3270.c > index 097d384..2ae58d0 100644 > --- a/drivers/s390/char/fs3270.c > +++ b/drivers/s390/char/fs3270.c > @@ -465,7 +465,7 @@ fs3270_open(struct inode *inode, struct file *filp) > if (IS_ERR(ib)) { > raw3270_put_view(&fp->view); > raw3270_del_view(&fp->view); > - rc = PTR_ERR(fp); > + rc = PTR_ERR(ib); > goto out; > } > fp->rdbuf = ib;
And added this one as well.
-- blue skies, Martin.
"Reality continues to ruin my life." - Calvin.
| |