Messages in this thread | | | From | Ryusuke Konishi <> | Date | Mon, 07 Dec 2009 18:29:34 +0900 | Subject | Re: + task_struct-make-journal_info-conditional.patch added to -mm tree |
| |
>Alexey Dobriyan wrote: >> On Fri, Dec 04, 2009 at 12:58:06PM +0900, Hiroshi Shimamoto wrote: >>> Alexey Dobriyan wrote: >>>> On Thu, Dec 03, 2009 at 02:40:57PM -0800, akpm@linux-foundation.org wrote: >>>>> --- a/include/linux/sched.h~task_struct-make-journal_info-conditional >>>>> +++ a/include/linux/sched.h >>>>> @@ -1452,8 +1452,10 @@ struct task_struct { >>>>> gfp_t lockdep_reclaim_gfp; >>>>> #endif >>>>> >>>>> +#ifdef CONFIG_FS_JOURNAL_INFO >>>>> /* journalling filesystem info */ >>>>> void *journal_info; >>>>> +#endif >>>> This will prevent using e.g. ext3 on CONFIG_EXT3_FS=n kernels. >>> I'm sorry, I'm not sure what you're mentioning. >> >> With this patch admin must decide in advance if he will ever use ext3. >> EXT3_FS=n kernels won't be able to get ext3 support without reboot >> even as module, because task_struct will be different. > >I see, you want to keep this field for future use even if EXT3_FS=n. >I think, however, there might be a need to remove this because the user >never enable any journaling filesystem.
Do you have some background to remove the "void *" from task_struct? You need it for embedded purpose?
Ryusuke Konishi
| |