Messages in this thread | | | Date | Mon, 7 Dec 2009 10:02:22 +0800 | From | Wu Fengguang <> | Subject | Re: [RFC] print symbolic page flag names in bad_page() |
| |
On Mon, Dec 07, 2009 at 07:00:16AM +0800, Andi Kleen wrote: > > So how about this patch? > > I like it. Decoding the flags by hand is always a very unpleasant experience. > Bonus: dump_page can be called from kgdb too.
Thank you. And I'd like to elaborate a bit more on the rational.
Making the page-types tool depend on .config is fragile and dangerous. It would seem to work but silently return wrong results for a newbie user or a careless hacker.
And it's troublesome even for home made kernels by a kernel developer.
For example, typically I run many kernel trees with different versions and kconfigs (both of which change frequently) concurrently. This means I would have to judge to run "this" page-types or "that" page-types, and to check if this page-types is uptodate, and if the .config is in sync with the running kernel image..
An in-kernel dump_page() makes life easier.
Thanks, Fengguang
| |