Messages in this thread Patch in this message | | | Date | Sun, 06 Dec 2009 15:30:44 -0800 | From | Greg KH <> | Subject | [12/20] fuse: reject O_DIRECT flag also in fuse_create |
| |
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------ From: Csaba Henk <csaba@gluster.com>
commit 1b7323965a8c6eee9dc4e345a7ae4bff1dc93149 upstream.
The comment in fuse_open about O_DIRECT:
"VFS checks this, but only _after_ ->open()"
also holds for fuse_create, however, the same kind of check was missing there.
As an impact of this bug, open(newfile, O_RDWR|O_CREAT|O_DIRECT) fails, but a stub newfile will remain if the fuse server handled the implied FUSE_CREATE request appropriately.
Other impact: in the above situation ima_file_free() will complain to open/free imbalance if CONFIG_IMA is set.
Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Cc: Harshavardhana <harsha@gluster.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- fs/fuse/dir.c | 3 +++ 1 file changed, 3 insertions(+)
--- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -398,6 +398,9 @@ static int fuse_create_open(struct inode if (fc->no_create) return -ENOSYS; + if (flags & O_DIRECT) + return -EINVAL; + forget_req = fuse_get_req(fc); if (IS_ERR(forget_req)) return PTR_ERR(forget_req);
| |