Messages in this thread | | | Date | Sat, 05 Dec 2009 07:43:41 -0500 | From | William Allen Simpson <> | Subject | Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of previous line |
| |
Joe Perches wrote: > On Fri, 2009-12-04 at 14:10 +0100, Brice Goglin wrote: >> Joe Perches wrote: >>> Only files where David Miller is the primary git-signer. >>> wireless, wimax, ixgbe, etc are not modified. >> What's the point? Having them at the beginning of the next line is >> easier to read from my point of view. > > It's just a stupid consistency thing. > Brice, I've made my objection known on the LKML. Joe *agrees* that having them on the beginning of the line is preferred. Thousands of contributors throughout the tree agree.
This is entirely a Miller thing.
My main objection to these sweeping patches is that it makes it much more difficult to maintain and apply patches across different versions of the tree. We have already seen conflicts with other git maintained trees.
These patches should not be accepted to the main Linus tree.
| |