lkml.org 
[lkml]   [2009]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 28/31] Constify struct super_operations for 2.6.32 v1
    On Fri, Dec 04, 2009 at 11:47:15PM +0100, Emese Revfy wrote:
    > From: Emese Revfy <re.emese@gmail.com>
    >
    > Constify struct super_operations.

    What the _hell_ is that?

    > + struct inode *(* const alloc_inode)(struct super_block *sb);

    This is ugly and has all marks of cargo-cult patches. NAKed at least
    until you give exceptionally good reasons for doing that.


    \
     
     \ /
      Last update: 2009-12-06 02:25    [W:0.026 / U:0.392 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site