Messages in this thread |  | | | Date | Fri, 4 Dec 2009 10:36:04 +0100 | | From | Uwe Kleine-König <> | | Subject | Re: [RFC][PATCH 01/10] arm: mxc: New interrupt controller (TZIC) for i.MX5 family |
| |
Hi,
On Fri, Dec 04, 2009 at 04:47:01AM +0200, Amit Kucheria wrote: > Freescale i.MX51 processor uses a different interrupt controller. Add the > driver and fix the Makefile to account for it. > > Signed-off-by: Amit Kucheria <amit.kucheria@canonical.com> > --- > arch/arm/plat-mxc/Kconfig | 4 + > arch/arm/plat-mxc/Makefile | 9 ++- > arch/arm/plat-mxc/tzic.c | 180 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 192 insertions(+), 1 deletions(-) > create mode 100644 arch/arm/plat-mxc/tzic.c > > diff --git a/arch/arm/plat-mxc/Kconfig b/arch/arm/plat-mxc/Kconfig > index ca5c7c2..11bf691 100644 > --- a/arch/arm/plat-mxc/Kconfig > +++ b/arch/arm/plat-mxc/Kconfig > @@ -75,4 +75,8 @@ config ARCH_HAS_RNGA > > config ARCH_MXC_IOMUX_V3 > bool > + > +config MXC_TZIC > + bool > + depends on ARCH_MXC > endif The whole file arch/arm/plat-mxc/Kconfig is a big
if ARCH_MXC ... endif
so there is no need for "depends on ARCH_MXC"
> diff --git a/arch/arm/plat-mxc/Makefile b/arch/arm/plat-mxc/Makefile > index e3212c8..5be53ca 100644 > --- a/arch/arm/plat-mxc/Makefile > +++ b/arch/arm/plat-mxc/Makefile > @@ -3,7 +3,14 @@ > # > > # Common support > -obj-y := irq.o clock.o gpio.o time.o devices.o cpu.o system.o > +obj-y := clock.o gpio.o time.o devices.o cpu.o system.o > + > +# MX51 uses the TZIC interrupt controller, older platforms use AVIC > +ifeq ($(CONFIG_MXC_TZIC),y) > +obj-y += tzic.o > +else > +obj-y += irq.o > +endif We're not there yet, but in the future we want to build kernel images that run on (say) imx51 and imx27. In such a kernel we'd need irq.o *and* tzic.o. So don't kick out irq.o when CONFIG_MXC_TZIC but make that dependant on the other SOCs.
> diff --git a/arch/arm/plat-mxc/tzic.c b/arch/arm/plat-mxc/tzic.c > new file mode 100644 > index 0000000..3af8fc6 > --- /dev/null > +++ b/arch/arm/plat-mxc/tzic.c > [...] > +static void mxc_mask_irq(unsigned int irq) please add a namespace for these functions. There is already a function mxc_mask_irq. Giving the same name twice is possible but makes the code harder to understand.
> [...] > + * @param is_idle 1 if called in idle loop (enset registers); s/enset/unset/ ?
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |