Messages in this thread | | | Date | Fri, 04 Dec 2009 14:44:27 -0800 | From | John Johansen <> | Subject | Re: [PATCH] security: do not check mmap_min_addr on nommu systems |
| |
David Howells wrote: > Eric Paris <eparis@redhat.com> wrote: > >> +/* sec_flags for security_file_mmap */ >> +/* Only check the address portion */ >> +#define SECURITY_MMAP_ADDR_ONLY 0x01 >> +/* Do not do the address checks */ >> +#define SECURITY_MMAP_NOT_ADDR 0x02 > > I'm still not happy with the names assigned to these constants. > > Can we call them: > > #define SECURITY_MMAP_ADDR_CHECK_ONLY 0x01 > #define SECURITY_MMAP_SKIP_ADDR_CHECK 0x02 > > and then discard the comments? I do like these suggested names a little better. Either way I am happy with the patch.
| |