Messages in this thread | | | Date | Fri, 4 Dec 2009 11:02:28 -0800 | From | Randy Dunlap <> | Subject | Re: [PATCH] make gconfig: fix the "(NEW)" string |
| |
On Fri, 4 Dec 2009 19:38:24 +0100 (CET) matteo_cortese@fastwebnet.it wrote:
> The string "(NEW)" is added to those options that are not present in the > current config file, thus looking as new features. Alas, the logic seem > s to be inverted.
Did you just notice that thru source code inspection or via testing of gconfig?
> Signed-off-by: Matteo Cortese <matteo_cortese@fastwebnet.it> > ------ > > diff -u linux-source-2.6.26-old/scripts/kconfig/gconf.c linux-source-2.6 > .26/scripts/kconfig/gconf.c > --- linux-source-2.6.26-old/scripts/kconfig/gconf.c 2008-07-13 21:51:29. > 000000000 +0000 > +++ linux-source-2.6.26/scripts/kconfig/gconf.c 2009-01-03 00:52:57.0000 > 00000 +0000 > @@ -1174,7 +1174,7 @@ > > row[COL_OPTION] = > g_strdup_printf("%s %s", _(menu_get_prompt(menu)), > - sym && sym_has_value(sym) ? "(NEW)" : ""); > + sym && !sym_has_value(sym) ? "(NEW)" : ""); > > if (show_all && !menu_is_visible(menu)) > row[COL_COLOR] = g_strdup("DarkGray"); > > --
Well, for me, with just some random config file that has CONFIG_MODULES=y CONFIG_BLOCK=y
gconfig with this patch says:
Enable loadable module support Enable the block layer (NEW)
and gconfig without this patch says:
Enable loadable module support (NEW) Enable the block layer
I'm confuzed. Go figure.
--- ~Randy
| |