[lkml]   [2009]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] leds: Add LED class driver for regulator driven LEDs.
    On Wed, 2 Dec 2009 18:06:58 +0000
    Mark Brown <> wrote:

    > > + vcc = regulator_get(&pdev->dev, pdata->supply);
    > > + if (IS_ERR(vcc)) {
    > > + dev_err(&pdev->dev, "Cannot get vcc for %s\n", pdata->name);
    > > + return PTR_ERR(vcc);;
    > > + }
    > You almost certainly want regulator_get_exclusive() here; this driver
    > can't function properly if something else is using the regulator and
    > holding the LED on or off without it. You'll also want to check the
    > status of the LED on startup and update your internal status to match
    > that.

    When you refer to "the status of the LED on startup" do you mean a
    initial brightness value passed via leds-regulator platform data, or the
    initial status or the regulator itself?


    Antonio Ospite

    PGP public key ID: 0x4553B001

    A: Because it messes up the order in which people normally read text.
    Q: Why is top-posting such a bad thing?
    A: Top-posting.
    Q: What is the most annoying thing in e-mail?
    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2009-12-04 13:43    [W:0.021 / U:35.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site