Messages in this thread | | | Date | Thu, 31 Dec 2009 01:44:47 +0100 | From | Frederic Weisbecker <> | Subject | Re: [RFC Patch 2/2][Bugfix][x86][hw-breakpoint] Fix return-code to notifier chain in hw_breakpoint_handler |
| |
On Sat, Dec 26, 2009 at 11:58:33PM +0530, K.Prasad wrote: > + /* > + * Further processing in do_debug() is needed for a) user-space > + * breakpoints (to generate signals) and b) when the system has > + * taken exception due to multiple causes > + */ > + if (bp->attr.bp_addr < TASK_SIZE) > + rc = NOTIFY_DONE;
BTW, I'm not sure this is the right way to check if we want to send a signal or not. Although it's not yet supported, we'll probably bring the support for userspace breakpoints by perf.
May be we should put a "ptrace" flag in struct hw_perf_event instead.
| |