lkml.org 
[lkml]   [2009]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC Patch 2/2][Bugfix][x86][hw-breakpoint] Fix return-code to notifier chain in hw_breakpoint_handler
On Sat, Dec 26, 2009 at 11:58:33PM +0530, K.Prasad wrote:
> + /*
> + * Further processing in do_debug() is needed for a) user-space
> + * breakpoints (to generate signals) and b) when the system has
> + * taken exception due to multiple causes
> + */
> + if (bp->attr.bp_addr < TASK_SIZE)
> + rc = NOTIFY_DONE;



BTW, I'm not sure this is the right way to check if we want to send
a signal or not. Although it's not yet supported, we'll probably
bring the support for userspace breakpoints by perf.

May be we should put a "ptrace" flag in struct hw_perf_event instead.



\
 
 \ /
  Last update: 2009-12-31 01:49    [W:0.099 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site