Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH 02/10] vfs: get_sb_single() - do not pass options twice | Date | Thu, 31 Dec 2009 04:30:11 +0900 |
| |
Kay Sievers <kay.sievers@vrfy.org> writes:
> On Sun, Dec 27, 2009 at 13:36, OGAWA Hirofumi > <hirofumi@mail.parknet.co.jp> wrote: >>> Filesystem code usually destroys the option buffer while >>> parsing it. This leads to errors when the same buffer is >>> passed twice. In case we fill a new superblock do not call >>> remount. > >> This breaks the historical behavior. Several users of get_sb_single() is >> parse data only on ->remount_fs. Well, ok, I like new behavior actually. >> But we need to convert to new behavior such users. >> >> I've listed all possibly affected users up (if I'm not missing). This >> means, using both data on ->fill_super and ->remount_fs is devtmpfs >> only. And capifs, usbfs, devpts would be needed the patch. > > Hmm, these filesystem are probably not going to overwrite their own > default options with their own special parameters to parse when they > allocate their superblock. That would be pretty weird, wouldn't it? > Seems they currently don't even pass "data" pointer around at that > time.
Oops, I was missing that those all fs was using kern_mount(). Sorry for noise. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |