[lkml]   [2009]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] cfq-iosched: replace sync_flight by rq_in_driver[BLK_RW_SYNC]
On Wed, Dec 30 2009, Corrado Zoccolo wrote:
> According to my intuition (and brief testing), sync_flight is always
> equal to rq_in_driver[BLK_RW_SYNC] at the point of usage, so it can
> be removed and replaced by the other.

They are not fully identical. ->sync_flight is incremented on insertion
on the dispatch list, ->rq_in_driver not until the request is activated
(eg the driver has retrieved it and wants to dispatch to the hardware).
They will usually be identical, but that may not be true for requeues
for instance.

Jens Axboe

 \ /
  Last update: 2009-12-30 19:51    [W:0.051 / U:1.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site