lkml.org 
[lkml]   [2009]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Should we use preempt_disable() in sleep_on_common()?
On Wed, Dec 02, 2009 at 11:12:44PM -0800, Dmitry Torokhov wrote:
> On Wed, Dec 02, 2009 at 11:07:46PM -0800, Arjan van de Ven wrote:
> > On Thu, 3 Dec 2009 14:49:14 +0800
> > liu pf <kernelfans@gmail.com> wrote:
> >
> > > Hi:
> > >
> > > I am puzzled with the following scenario. Could anyone enlighten me?
> >
> >
> > sleep_on family of APIs is very racy and just cannot be used correctly;
> > I'm not surprised that there's a preempt race in it, but trust me, it's
> > not the biggest race... never ever use these APIs!!!
> >
> >
>
> BTW, why do we still have them? I checked couple and they don't seem to
> be used...
>

Ah, my bad, I now see interruptible_sleep_on used all over drivers/char...

--
Dmitry


\
 
 \ /
  Last update: 2009-12-03 08:17    [W:0.049 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site