lkml.org 
[lkml]   [2009]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/3] perf tools: remove pid option from stat
    From
    Date
    On Tue, 2009-12-29 at 16:37 +0800, Liming Wang wrote:
    > pid option is useless for stat, so remove it.

    Hmm, it shouldn't be.. and instead of removing it I would suggesting
    fixing this.

    > Signed-off-by: Liming Wang <liming.wang@windriver.com>
    > ---
    > tools/perf/builtin-stat.c | 3 ---
    > 1 files changed, 0 insertions(+), 3 deletions(-)
    >
    > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
    > index c70d720..e3b31a3 100644
    > --- a/tools/perf/builtin-stat.c
    > +++ b/tools/perf/builtin-stat.c
    > @@ -71,7 +71,6 @@ static int run_idx = 0;
    > static int run_count = 1;
    > static int inherit = 1;
    > static int scale = 1;
    > -static pid_t target_pid = -1;
    > static pid_t child_pid = -1;
    > static int null_run = 0;
    >
    > @@ -471,8 +470,6 @@ static const struct option options[] = {
    > parse_events),
    > OPT_BOOLEAN('i', "inherit", &inherit,
    > "child tasks inherit counters"),
    > - OPT_INTEGER('p', "pid", &target_pid,
    > - "stat events on existing pid"),
    > OPT_BOOLEAN('a', "all-cpus", &system_wide,
    > "system-wide collection from all CPUs"),
    > OPT_BOOLEAN('c', "scale", &scale,




    \
     
     \ /
      Last update: 2009-12-29 13:07    [W:0.020 / U:149.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site