lkml.org 
[lkml]   [2009]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/5] drivers/scsi : Correct the size argument to kmalloc
    From
    Date
    On Tue, 2009-12-29 at 21:04 +0100, Julia Lawall wrote:
    > On Tue, 29 Dec 2009, Rolf Eike Beer wrote:
    > > Julia Lawall wrote:
    > > > From: Julia Lawall <julia@diku.dk>
    > > > In each case, the destination of the allocation has type struct **, so the
    > > > elements of the array should have pointer type, not structure type.
    > > Maybe they should even by kcalloc'ed?
    > I thought about that, but in response to another patch someone seemed to
    > think kcalloc was not very useful. But I can certainly change it in this
    > case.

    I think kcalloc is useful and should be used when the
    allocated array of elements needs to be zeroed.

    It appears the uses in 1/5 and 3/5 don't need it but
    maybe patch 2/5 and 4/5 should use kcalloc.




    \
     
     \ /
      Last update: 2009-12-29 22:25    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean