Messages in this thread | | | From | Bryan Donlan <> | Date | Tue, 29 Dec 2009 16:14:46 -0500 | Subject | Re: RFC: disablenetwork facility. (v4) |
| |
2009/12/29 Alan Cox <alan@lxorguk.ukuu.org.uk>: >> > Execute != read. The executable file may contain secrets which must not >> > be available to the user running the setuid program. If you fail the >> > setuid, the user will be able to ptrace() and then the secret is >> > revealed. >> > >> > It's amazing how many security holes appear from what seems like a very >> > simple request. >> >> Do we have a security hole in nosuid mount option? >> Can someone write a patch to fix it? > > If a setuid app can read a key when its erroneously not set setuid then > the user can read it too. > > Anything you can do with ptrace you can do yourself !
The security hole is that secrets in a setuid application with other-exec but no other-read permission can be read when the filesystem is mounted nosuid. Normally the user would be unable to ptrace the program, and unable to read the executable, so the secret would not be divulged; when nosuid is set, the user is now able to ptrace the program - ie, they gain abilities from nosuid.
Whether this is a severe issue is debatable, of course; it's unlikely that the administrator will create a setuid program with weird permissions and then go and mount the fs it's on with nosuid. However with the proposed 'drop suiding abilities' API, this becomes a bigger issue, since if we reuse the nosuid semantics, any user can trigger it, without needing to get root to mount things nosuid.
That said, I do tend to agree that relying on the _presence_ of a suid mode to protect your secrets is probably a bad idea...
| |