Messages in this thread | | | Subject | Re: [PATCH] OMAP2: add USB platform data and initialization for Nokia N800 and N810 | From | Kalle Valo <> | Date | Tue, 29 Dec 2009 10:29:22 +0200 |
| |
"Luke-Jr" <luke@dashjr.org> writes:
> Add platform data and initialization for USB on Nokia N800 and N810 devices > via the TUSB6010 chipset.
Excellent, thank you for doing this.
> Tested on Nokia N810 in Linux-OMAP tree. Mainline is not bootable yet.
What's the problem in mainline? I haven't tested n8x0 for months :(
> --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -117,6 +117,11 @@ config MACH_NOKIA_N8X0 > select MACH_NOKIA_N810 > select MACH_NOKIA_N810_WIMAX > > +config MACH_NOKIA_N8X0_USB > + bool > + depends on MACH_NOKIA_N8X0 && MACH_OMAP2_TUSB6010 > + default y > +
Is is really needed to add new kconfig variable? Can't we just use MACH_OMAP2_TUSB6010 in code?
> --- /dev/null > +++ b/arch/arm/mach-omap2/board-n8x0-usb.c
I think a separate file is not needed, it's not that much code. I recommend to just adding it directly to board-n8x0.c. It's simple and easier for everyone.
> --- a/arch/arm/mach-omap2/board-n8x0.c > +++ b/arch/arm/mach-omap2/board-n8x0.c > @@ -109,8 +109,16 @@ static void __init n8x0_init_irq(void) > omap_gpio_init(); > } > > +#ifdef CONFIG_MACH_NOKIA_N8X0_LCD > +extern void n8x0_usb_init(void); > +#else > +static inline void n8x0_usb_init (void) {} > +#endif
CONFIG_MACH_NOKIA_N8X0_LCD does not look right here.
-- Kalle Valo
| |