lkml.org 
[lkml]   [2009]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] input: imon driver for SoundGraph iMON/Antec Veris IR devices
On 12/29/2009 12:01 PM, Dan Carpenter wrote:
>
> I ran smatch (http://repo.or.cz/w/smatch.git) on it and there are
> some bugs worth fixing.
>
> drivers/input/misc/imon.c +331 free_imon_context(7) error: dereferencing freed memory 'context'
> Move the debug line earlier.
>
> drivers/input/misc/imon.c +1812 imon_probe(216) error: dereferencing undefined: 'context->idev'
> drivers/input/misc/imon.c +1876 imon_probe(280) error: dereferencing undefined: 'context->touch'
> The allocation func can return NULL. They probably won't fail in real
> life, but it will slightly annoy every person checking running smatch
> over the entire kernel (me).
>
> drivers/input/misc/imon.c +1979 imon_probe(383) error: double unlock 'mutex:&context->lock'
> drivers/input/misc/imon.c +1983 imon_probe(387) error: double unlock 'mutex:&context->lock'
> It sometimes unlocks both before and after the goto.

Yeah, I think I've actually already fixed every one of these problems in
the past 24 hours (a few just a few minutes ago), stay tuned for a
repost, hopefully later today. :)

Thanks much,

--
Jarod Wilson
jarod@wilsonet.com


\
 
 \ /
  Last update: 2009-12-29 19:15    [W:0.169 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site