lkml.org 
[lkml]   [2009]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: On "ratelimit: Use per ratelimit context locking"
Ingo Molnar wrote:
> There used to be a global lock:
>
> static DEFINE_SPINLOCK(ratelimit_lock);
>
> which is now per ratelimit context. The case i was after was to use the
> ratelimit state from NMI context. With NMIs we can lock up if an NMI hits when
> some other code uses the ratelimit code. It's a small but existing race
> window.

Ah, I see.

> OTOH, IRQ context use of printk ratelimit was safe before (and after) this
> commit - so i think your code should be safe too.

Thanks for the explanation; that's reassuring.
--
Stefan Richter
-=====-==--= ==-- ===-=
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2009-12-29 03:05    [W:0.052 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site