Messages in this thread | | | Date | Tue, 29 Dec 2009 02:56:04 +0100 | From | Stefan Richter <> | Subject | Re: On "ratelimit: Use per ratelimit context locking" |
| |
Ingo Molnar wrote: > There used to be a global lock: > > static DEFINE_SPINLOCK(ratelimit_lock); > > which is now per ratelimit context. The case i was after was to use the > ratelimit state from NMI context. With NMIs we can lock up if an NMI hits when > some other code uses the ratelimit code. It's a small but existing race > window.
Ah, I see.
> OTOH, IRQ context use of printk ratelimit was safe before (and after) this > commit - so i think your code should be safe too.
Thanks for the explanation; that's reassuring. -- Stefan Richter -=====-==--= ==-- ===-= http://arcgraph.de/sr/
| |