lkml.org 
[lkml]   [2009]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] cgroups: subsystem module loading interface
>>> +	write_lock(&css_set_lock);
>>> + for (i = 0; i < CSS_SET_TABLE_SIZE; i++) {
>>> + struct css_set *cg;
>>> + struct hlist_node *node, *tmp;
>>> + struct hlist_head *bucket = &css_set_table[i], *new_bucket;
>> Please add a blank line between variable declaration and other code.
>>
>> And elsewhere in this patchset.
>>
>
> checkpatch.pl didn't trip on this [and the more screenspace-intensive
> comment style]; are they cgroups-specific style requirements or from
> somewhere higher up?
>

You'll find the comment style in Documentation/CodingStyle:

==============
The preferred style for long (multi-line) comments is:
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/
==============
Though the other coding style is not documented, I think it's
well accepted.

You'll hardly find code that breaks this style, say in kernel/* and
mm/*. And you can see that people pointed out this when they were
reviewing patches.
And the fact is it does make the code more readable.


\
 
 \ /
  Last update: 2009-12-29 02:07    [from the cache]
©2003-2011 Jasper Spaans