lkml.org 
[lkml]   [2009]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] atarilance: timeout ignored in lance_open()
    With `while (--limit > 0)' i reaches 0 after the loop, so upon timeout the
    error was not returned.

    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    ---
    diff --git a/drivers/net/niu.c b/drivers/net/niu.c
    index 8ce58c4..2aed2b3 100644
    --- a/drivers/net/niu.c
    +++ b/drivers/net/niu.c
    @@ -2844,7 +2844,7 @@ static int tcam_wait_bit(struct niu *np, u64 bit)
    break;
    udelay(1);
    }
    - if (limit < 0)
    + if (limit <= 0)
    return -ENODEV;

    return 0;

    \
     
     \ /
      Last update: 2009-12-27 14:29    [W:0.038 / U:92.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site