lkml.org 
[lkml]   [2009]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 0/4] cgroup notifications API and memory thresholds
On Sun, 27 Dec 2009 04:08:58 +0200
"Kirill A. Shutemov" <kirill@shutemov.name> wrote:

> This patchset introduces eventfd-based API for notifications in cgroups and
> implements memory notifications on top of it.
>
> It uses statistics in memory controler to track memory usage.
>
> Output of time(1) on building kernel on tmpfs:
>
> Root cgroup before changes:
> make -j2 506.37 user 60.93s system 193% cpu 4:52.77 total
> Non-root cgroup before changes:
> make -j2 507.14 user 62.66s system 193% cpu 4:54.74 total
> Root cgroup after changes (0 thresholds):
> make -j2 507.13 user 62.20s system 193% cpu 4:53.55 total
> Non-root cgroup after changes (0 thresholds):
> make -j2 507.70 user 64.20s system 193% cpu 4:55.70 total
> Root cgroup after changes (1 thresholds, never crossed):
> make -j2 506.97 user 62.20s system 193% cpu 4:53.90 total
> Non-root cgroup after changes (1 thresholds, never crossed):
> make -j2 507.55 user 64.08s system 193% cpu 4:55.63 total
>
> Any comments?
>
Hmm, 2 secs of overhead is added by this.
(larger than expected.)

But optimization/claun up after merging is okay to me because the function
itself is attractive.

Thanks,
-Kame



> v3 -> v4:
> - documentation.
>
> v2 -> v3:
> - remove [RFC];
> - rebased to 2.6.33-rc2;
> - fixes based on comments;
> - fixed potential race on event removing;
> - use RCU-protected arrays to track trasholds.
>
> v1 -> v2:
> - use statistics instead of res_counter to track resource usage;
> - fix bugs with locking.
>
> v0 -> v1:
> - memsw support implemented.
>
> Kirill A. Shutemov (4):
> cgroup: implement eventfd-based generic API for notifications
> memcg: extract mem_group_usage() from mem_cgroup_read()
> memcg: rework usage of stats by soft limit
> memcg: implement memory thresholds
>
> Documentation/cgroups/cgroups.txt | 20 ++
> Documentation/cgroups/memory.txt | 19 ++-
> include/linux/cgroup.h | 24 +++
> kernel/cgroup.c | 208 ++++++++++++++++++++++-
> mm/memcontrol.c | 348 ++++++++++++++++++++++++++++++++++---
> 5 files changed, 590 insertions(+), 29 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



\
 
 \ /
  Last update: 2009-12-28 03:33    [W:0.187 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site