lkml.org 
[lkml]   [2009]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 10/37] kgdb: Make mem access function weak in kgdb.c and kgdb.h
On Wed, Dec 23, 2009 at 16:19, Jason Wessel wrote:
> L1 instruction memory and MMR memory on blackfin can not be accessed by
> common functions probe_kernel_read() and probe_kernel_write().
> Blackfin asks for 2/4 byte align access to MMR memory and DMA access to
> L1 instruction memory. These functions need to be reimplemented in
> architecture specific kgdb.c. Update documentation and prototypes as
> well.

considering these functions were made weak only because of
probe_kernel_(read|write), then perhaps it makes more sense to move
the work there. it would mean that all consumers of these functions
work properly instead of just kgdb.

probe_kernel_write is already weak ... we just need to add weak to
probe_kernel_read i think, and make the functions available via a
"default" symbol so that arch overrides can tail back into the common
code when it makes sense.
-mike


\
 
 \ /
  Last update: 2009-12-26 22:09    [W:0.259 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site