Messages in this thread Patch in this message | | | Date | Wed, 23 Dec 2009 17:58:27 +0800 | From | Haicheng Li <> | Subject | [PATCH v2] slab: initialize unused alien cache entry as NULL at alloc_alien_cache(). |
| |
Memory hotplug would online new node in runtime, then reap timer will add this new node as a reap node. In such case, for each existing kmem_list, we need to ensure that the alien cache entry corresponding to this new added node is NULL.
Otherwise, it might cause BUG when reap_alien() affecting the new added node.
V2: use kzalloc_node() to ensure zeroed memory.
CC: Pekka Enberg <penberg@cs.helsinki.fi> Acked-by: Andi Kleen <ak@linux.intel.com> Reviewed-by: Christoph Lameter <cl@linux-foundation.org> Reviewed-by: Matt Mackall <mpm@selenic.com> Signed-off-by: Haicheng Li <haicheng.li@linux.intel.com> --- mm/slab.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/mm/slab.c b/mm/slab.c index 7dfa481..000e9ed 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -966,18 +966,16 @@ static void *alternate_node_alloc(struct kmem_cache *, gfp_t); static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t gfp) { struct array_cache **ac_ptr; - int memsize = sizeof(void *) * nr_node_ids; + int memsize = sizeof(void *) * MAX_NUMNODES; int i;
if (limit > 1) limit = 12; - ac_ptr = kmalloc_node(memsize, gfp, node); + ac_ptr = kzalloc_node(memsize, gfp, node); if (ac_ptr) { for_each_node(i) { - if (i == node || !node_online(i)) { - ac_ptr[i] = NULL; + if (i == node || !node_online(i)) continue; - } ac_ptr[i] = alloc_arraycache(node, limit, 0xbaadf00d, gfp); if (!ac_ptr[i]) { for (i--; i >= 0; i--) -- 1.5.3.8
| |