Messages in this thread Patch in this message | | | Date | Mon, 21 Dec 2009 20:03:19 +0800 | From | Liuwenyi <> | Subject | [PATCHv2 12/12]posix_acl: Add the check items |
| |
move the ACL validation check in to fs/posix_acl.c. Including nullpointer check and PTR_ERR check.
--- Signed-off-by: Liuwenyi <qingshenlwy@gmail.com> Cc: Alex Elder <aelder@sgi.com> Cc: xfs-masters@oss.sgi.com Cc :Christoph Hellwig <hch@lst.de> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Eric Sandeen <sandeen@sandeen.net> Cc: Joel Becker <joel.becker@oracle.com> Cc: xfs@oss.sgi.com Cc: linux-kernel@vger.kernel.org
--- diff --git a/fs/xfs/linux-2.6/xfs_acl.c b/fs/xfs/linux-2.6/xfs_acl.c index 2512125..3de2533 100644 --- a/fs/xfs/linux-2.6/xfs_acl.c +++ b/fs/xfs/linux-2.6/xfs_acl.c @@ -392,17 +392,6 @@ xfs_xattr_acl_set(struct dentry *dentry, const char *name, goto set_acl;
acl = posix_acl_from_xattr(value, size); - if (!acl) { - /* - * acl_set_file(3) may request that we set default ACLs with - * zero length -- defend (gracefully) against that here. - */ - goto out; - } - if (IS_ERR(acl)) { - error = PTR_ERR(acl); - goto out; - }
error = posix_acl_valid(acl); if (error)
-- Best Regards, Liuwenyi
| |