Messages in this thread Patch in this message | | | Date | Mon, 21 Dec 2009 20:01:53 +0800 | From | Liuwenyi <> | Subject | [PATCHv2 11/12]posix_acl: Add the check items |
| |
move the ACL validation check in to fs/posix_acl.c. Including nullpointer check and PTR_ERR check.
--- Signed-off-by: Liuwenyi <qingshenlwy@gmail.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Jeff Mahoney <jeffm@suse.com> Cc: Joel Becker <joel.becker@oracle.com> Cc: James Morris <jmorris@namei.org> Cc: Christoph Hellwig <hch@lst.de> Cc: reiserfs-devel@vger.kernel.org Cc: linux-kernel@vger.kernel.org
--- diff --git a/fs/reiserfs/xattr_acl.c b/fs/reiserfs/xattr_acl.c index cc32e6a..4cf1f18 100644 --- a/fs/reiserfs/xattr_acl.c +++ b/fs/reiserfs/xattr_acl.c @@ -30,13 +30,9 @@ posix_acl_set(struct dentry *dentry, const char *name, const void *value,
if (value) { acl = posix_acl_from_xattr(value, size); - if (IS_ERR(acl)) { - return PTR_ERR(acl); - } else if (acl) { - error = posix_acl_valid(acl); - if (error) - goto release_and_out; - } + error = posix_acl_valid(acl); + if (error) + goto release_and_out; } else acl = NULL;
-- Best Regards, Liuwenyi
| |