Messages in this thread Patch in this message | | | Date | Mon, 21 Dec 2009 19:56:30 +0800 | From | Liuwenyi <> | Subject | [PATCHv2 04/12]posix_acl: Add the check items |
| |
move the ACL validation check in to fs/posix_acl.c. Including nullpointer check and PTR_ERR check.
---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andreas Dilger <adilger@sun.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: James Morris <jmorris@namei.org> Cc: Joel Becker <joel.becker@oracle.com> Cc: Serge Hallyn <serue@us.ibm.com> Cc: Jan Kara <jack@suse.cz> Cc: linux-ext4@vger.kernel.org Cc: linux-kernel@vger.kernel.org
--- diff --git a/fs/ext3/acl.c b/fs/ext3/acl.c index 82ba341..3758304 100644 --- a/fs/ext3/acl.c +++ b/fs/ext3/acl.c @@ -432,13 +432,11 @@ ext3_xattr_set_acl(struct dentry *dentry, const char *name, const void *value,
if (value) { acl = posix_acl_from_xattr(value, size); - if (IS_ERR(acl)) - return PTR_ERR(acl); - else if (acl) { - error = posix_acl_valid(acl); - if (error) - goto release_and_out; - } + + error = posix_acl_valid(acl); + if (error) + goto release_and_out; + } else acl = NULL;
-- Best Regards, Liuwenyi
| |