Messages in this thread | | | Date | Mon, 21 Dec 2009 11:50:10 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] [0/11] SYSCTL: Use RCU to avoid races with string sysctls |
| |
On Mon, Dec 21, 2009 at 09:57:32AM +0200, Alexey Dobriyan wrote: > > new = alloc_rcu_string(MAX_GLOBAL_SIZE, GFP_KERNEL); > > I think adding failure mode is not right. > We can get away with per-sysctl-string spinlock and not introduce yet > another API.
You mean when running out of memory here?
When this runs out of memory the system will be not usable anyways and on the last legs and likely in a deadly swap storm.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |