Messages in this thread | | | Date | Tue, 22 Dec 2009 02:10:06 +0100 | Subject | Re: [REGRESSION] um: CONFIG_STATIC_LINK=y broken | From | richard -rw- weinberger <> |
| |
Adding the ALIGN(PAGE_SIZE) causes the segfault. But I cannot tell you why. :-(
Cheers, //richard
2009/12/22, Tim Abbott <tabbott@ksplice.com>: > On Tue, 22 Dec 2009, richard -rw- weinberger wrote: > >> This is the bad changeset: > > Thanks for tracking that down. INIT_TEXT_SECTION is: > > #define INIT_TEXT_SECTION(inittext_align) \ > . = ALIGN(inittext_align); \ > .init.text : AT(ADDR(.init.text) - LOAD_OFFSET) { \ > VMLINUX_SYMBOL(_sinittext) = .; \ > INIT_TEXT \ > VMLINUX_SYMBOL(_einittext) = .; \ > } > > So there are only 3 code changes here: > (1) wrapping _sinittext and _einittext in VMLINUX_SYMBOL > (2) Adding the AT(ADDR(.init.text) - LOAD_OFFSET) > (3) The added ALIGN(PAGE_SIZE) before the start of .init.text. > > I don't yet see why any of these would be problematic; would you be > willing to try them and figure out the precise cause? > > I suspect it'd be easiest for you to try those individual changes > interactively, but if it's not trivial for you, I'd be happy to generate a > patch series splitting out this change into pieces for you to bisect. > > -Tim Abbott >
| |