lkml.org 
[lkml]   [2009]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] m68knommu: Fix invalid flags on coldfire pit clocksource
    From
    Date
    Just re-sending this in case it was missed. Steven tested this and it
    seems to be the right fix. Should be 2.6.33 material.

    thanks
    -john



    The m68knommu coldfire pit clocksource looks like it was incorrectly
    marked as a continuous clocksource. Running with it marked as a
    continuous clocksource could cause hangs when the system switches to
    highres mode or enables nohz.

    This patch removes the CLOCK_SOURCE_IS_CONTINUOUS flag on the coldfire
    pit clocksource. This will disallow systems using this clocksource from
    entering oneshot mode (disabling highres timers and nohz).

    Signed-off-by: John Stultz <johnstul@us.ibm.com>

    ---

    diff --git a/arch/m68knommu/platform/coldfire/pit.c b/arch/m68knommu/platform/coldfire/pit.c
    index d8720ee..aebea19 100644
    --- a/arch/m68knommu/platform/coldfire/pit.c
    +++ b/arch/m68knommu/platform/coldfire/pit.c
    @@ -146,7 +146,6 @@ static struct clocksource pit_clk = {
    .read = pit_read_clk,
    .shift = 20,
    .mask = CLOCKSOURCE_MASK(32),
    - .flags = CLOCK_SOURCE_IS_CONTINUOUS,
    };

    /***************************************************************************/




    \
     
     \ /
      Last update: 2009-12-22 01:41    [W:0.022 / U:184.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site